Skip to content

fix: set taxes and totals before validating subcontracting transaction (backport #3782)#3960

Merged
mergify[bot] merged 3 commits intoversion-15-hotfixfrom
mergify/bp/version-15-hotfix/pr-3782
Feb 6, 2026
Merged

fix: set taxes and totals before validating subcontracting transaction (backport #3782)#3960
mergify[bot] merged 3 commits intoversion-15-hotfixfrom
mergify/bp/version-15-hotfix/pr-3782

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Feb 6, 2026

Fixes: #3777

Summary by CodeRabbit

  • Refactor

    • Tax initialization now runs earlier and only once, preventing duplicate calculations.

  • Bug Fixes / Tests

    • total_taxes now shows 0.0 (not blank) for subcontracting orders with unregistered entities and for material receipt stock entries.

  • Tests

    • Updated ITC-04 export expectations: adjusted an item's reported value from 0.0 to 200.0.
This is an automatic backport of pull request #3782 done by [Mergify](https://mergify.com).

@mergify mergify Bot mentioned this pull request Feb 6, 2026
Merged
@mergify mergify Bot merged commit b6c561f into version-15-hotfix Feb 6, 2026
12 checks passed
@mergify mergify Bot deleted the mergify/bp/version-15-hotfix/pr-3782 branch February 6, 2026 06:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.89%. Comparing base (8ca7140) to head (f28b5b0).
⚠️ Report is 42 commits behind head on version-15-hotfix.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           version-15-hotfix    #3960   +/-   ##
==================================================
  Coverage              59.89%   59.89%           
==================================================
  Files                    140      140           
  Lines                  14879    14879           
==================================================
  Hits                    8912     8912           
  Misses                  5967     5967
Files with missing lines Coverage Δ
.../gst_india/overrides/subcontracting_transaction.py 84.78% <100.00%> (ø)

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@india-compliance-bot
Copy link
Copy Markdown
Collaborator

india-compliance-bot commented Feb 13, 2026

🎉 This PR is included in version 15.25.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@india-compliance-bot @karm1000
⚡